From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsFNk-0002yg-CR for qemu-devel@nongnu.org; Tue, 31 Jan 2012 10:12:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsFNe-0001Jj-Ln for qemu-devel@nongnu.org; Tue, 31 Jan 2012 10:12:28 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:50615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsFNe-0001Jf-FW for qemu-devel@nongnu.org; Tue, 31 Jan 2012 10:12:22 -0500 Received: by yenl10 with SMTP id l10so72463yen.4 for ; Tue, 31 Jan 2012 07:12:22 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F2804CE.40407@redhat.com> Date: Tue, 31 Jan 2012 16:12:14 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F27F6CD.1000807@codemonkey.ws> In-Reply-To: <4F27F6CD.1000807@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Developers qemu-devel , Mitsyanko Igor , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , KVM devel mailing list , quintela@redhat.com On 01/31/2012 03:12 PM, Anthony Liguori wrote: > > Don't use VMState. Just open code a save/restore function. VMState is > too limited in how it handles complex data structures. > > I really believe the only long term solution we're going to get to here > is something that uses a builder interface (like Visitors). Visitors for complex data structures still require you separate get/set functions. VMState was created to avoid having to write things twice and avoid getting the two out of sync. Paolo