From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RsH3E-00021W-Co
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:59:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RsH38-00016b-9B
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:59:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30878)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RsH37-00016S-Vh
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:59:18 -0500
Message-ID: <4F281DE0.1010503@redhat.com>
Date: Tue, 31 Jan 2012 17:59:12 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com>	<1327604460-31142-7-git-send-email-aliguori@us.ibm.com>	<4F27FBE6.7040800@siemens.com>
	<4F27FEFD.5070507@codemonkey.ws>	<4F28000B.5060406@siemens.com>
	<4F280184.3080607@redhat.com>	<4F2812E3.6010206@codemonkey.ws>
	<4F281498.9030406@siemens.com> <4F281B11.2050306@codemonkey.ws>
In-Reply-To: <4F281B11.2050306@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through
	composition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>

On 01/31/2012 05:47 PM, Anthony Liguori wrote:
>>
>
> static void object_initialize(Object *obj)
> {
>      PIIX3State *s = PIIX3(obj);
>      ChildProperty props[] = {
>        { "pic[0]", TYPE_I8259, &s->pic[0] },
>        { "pic[1]", TYPE_I8259, &s->pic[1] },
>      };
>
>      object_property_add_children(obj, props, ARRAY_SIZE(props));
> }
>
> Is much nicer IMHO.

Fine, but then children devices will not use the same memory block as 
the parent.  Not a huge difference, but worth pointing it out.

Paolo