Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

On 2012-01-31 22:40, Anthony Liguori wrote:
> On 01/31/2012 12:46 PM, Jan Kiszka wrote:
>> Applying the concept used for the *PICs once again: establish a base
>> class for the i8254 that can be used both by the current user space
>> emulation and the upcoming KVM in-kernel version. We share most of the
>> public interface of the i8254, specifically to the pcspk, vmstate, reset
>> and certain init parts.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> 
> Now that we have QOM bits, there's no need to factor out a common base
> class.
> 
> Just make the methods that you want to override virtual with the default
> implementation and then make a KVMPIT that inherits from the PIT and
> then overrides whatever virtual functions it needs to.

That doesn't sound like the proper design for this purpose. Rather, we
have an abstract base class that both implementations are derived from.
If I'm not using QOM properly to achieve this, please tell me.

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]