From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account
Date: Tue, 31 Jan 2012 23:24:20 +0100 [thread overview]
Message-ID: <4F286A14.7090100@reactos.org> (raw)
In-Reply-To: <m3pqe0usp1.fsf@blackfin.pond.sub.org>
Hi,
Markus Armbruster a écrit :
>>> Are single sided floppies broken before the patch? How?
>> Yes. For head > 0, wrong sector number is calculated, so data is
>> read/written at wrong place on underlying block device.
>>
>> Fortunately, mostly nobody is still using single-sided floppies (only
>> some 360 kB floppies are single-sided), so bug has been neglected
>> since a long time.
>
> Nice info, thanks. Best put it in the commit message.
Will do when respinning the serie
Hervé
next prev parent reply other threads:[~2012-01-31 22:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 8:50 [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account Hervé Poussineau
2012-01-27 8:38 ` Markus Armbruster
2012-01-27 20:11 ` Hervé Poussineau
2012-01-31 9:28 ` Markus Armbruster
2012-01-31 22:24 ` Hervé Poussineau [this message]
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 2/9] fdc: set busy bit when starting a command Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 3/9] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 4/9] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-01-27 8:43 ` Markus Armbruster
2012-01-27 20:03 ` Hervé Poussineau
2012-01-31 9:31 ` Markus Armbruster
2012-01-31 22:16 ` Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 6/9] block: add a transfer rate for floppy types Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-01-27 8:56 ` Markus Armbruster
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 8/9] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 9/9] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
2012-01-27 8:57 ` Markus Armbruster
2012-01-31 9:34 ` [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Markus Armbruster
2012-01-31 22:22 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F286A14.7090100@reactos.org \
--to=hpoussin@reactos.org \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).