From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsUdq-00083C-FM
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:30:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsUdj-0006wh-Ti
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:30:05 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:46953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsUdj-0006vp-Mm
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:29:59 -0500
Received: by dadp14 with SMTP id p14so805356dad.4
	for <qemu-devel@nongnu.org>; Tue, 31 Jan 2012 23:29:58 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F28E9EF.9000706@redhat.com>
Date: Wed, 01 Feb 2012 08:29:51 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1328031687.git.jan.kiszka@siemens.com>
	<c101f29d71634c6c8d70a14d59664e75f11b7d3f.1328031687.git.jan.kiszka@siemens.com>
	<4F2853EA.3030808@codemonkey.ws>
In-Reply-To: <4F2853EA.3030808@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>

On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>
>> +        DEFINE_PROP_HEX32("iobase", PCSpkState, iobase,  -1),
>> +        DEFINE_PROP_PTR("pit", PCSpkState, pit),
>
> Please don't introduce a pointer property here.  They cannot be used in
> a meaningful way in qdev.  Why not register a link<TYPE_PIT> in
> instance_init?

I'm going to clean this up, you can leave the PTR for now.

Paolo