From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev
Date: Wed, 01 Feb 2012 10:18:41 +0100 [thread overview]
Message-ID: <4F290371.1040601@siemens.com> (raw)
In-Reply-To: <4F28E9EF.9000706@redhat.com>
On 2012-02-01 08:29, Paolo Bonzini wrote:
> On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>>
>>> + DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1),
>>> + DEFINE_PROP_PTR("pit", PCSpkState, pit),
>>
>> Please don't introduce a pointer property here. They cannot be used in
>> a meaningful way in qdev. Why not register a link<TYPE_PIT> in
>> instance_init?
>
> I'm going to clean this up, you can leave the PTR for now.
OK, will then ship v4 with this property still in place and count on you.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-02-01 9:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 17:41 [Qemu-devel] [PATCH v3 0/7] pit, hpet, pcspk: fixes & preparation for KVM Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 1/7] i8254: Do not raise IRQ level on reset Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 2/7] hpet: Save/restore cached RTC IRQ level Jan Kiszka
2012-01-31 21:02 ` Anthony Liguori
2012-01-31 22:05 ` Jan Kiszka
2012-01-31 22:38 ` Anthony Liguori
2012-01-31 22:39 ` Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 3/7] i8254: Factor out interface header Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 4/7] i8254: Pass alternative IRQ output object on initialization Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 5/7] i8254: Rework & fix interaction with HPET in legacy mode Jan Kiszka
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev Jan Kiszka
2012-01-31 20:49 ` Anthony Liguori
2012-01-31 22:00 ` Jan Kiszka
2012-01-31 22:40 ` Anthony Liguori
2012-01-31 22:48 ` Jan Kiszka
2012-01-31 23:23 ` Anthony Liguori
2012-02-01 7:29 ` Paolo Bonzini
2012-02-01 9:18 ` Jan Kiszka [this message]
2012-01-31 17:41 ` [Qemu-devel] [PATCH v3 7/7] i8254: Factor out pit_get_channel_info Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F290371.1040601@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).