From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsZEI-0002zl-MD
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 07:24:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsZEA-000576-V6
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 07:24:02 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:40138)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RsZEA-00055F-OR
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 07:23:54 -0500
Received: by pbaa11 with SMTP id a11so1336241pba.4
	for <qemu-devel@nongnu.org>; Wed, 01 Feb 2012 04:23:52 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F292ED1.3060901@redhat.com>
Date: Wed, 01 Feb 2012 13:23:45 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1328035553.git.jan.kiszka@siemens.com>
	<1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com>
	<4F285FBA.5050607@codemonkey.ws> <4F2861F4.1000604@web.de>
In-Reply-To: <4F2861F4.1000604@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM
 reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Marcelo Tosatti <mtosatti@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>

On 01/31/2012 10:49 PM, Jan Kiszka wrote:
> >  Just make the methods that you want to override virtual with the default
> >  implementation and then make a KVMPIT that inherits from the PIT and
> >  then overrides whatever virtual functions it needs to.
>
> That doesn't sound like the proper design for this purpose. Rather, we
> have an abstract base class that both implementations are derived from.

Absolutely!

> If I'm not using QOM properly to achieve this, please tell me.

It looks good, besides the need to rebase to Anthony's "part 3" changes.

Paolo