From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rsa5y-0002p8-M4
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 08:19:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rsa5s-0001tn-Tq
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 08:19:30 -0500
Received: from mail-pz0-f46.google.com ([209.85.210.46]:56746)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rsa5s-0001si-Mv
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 08:19:24 -0500
Received: by dadp15 with SMTP id p15so1276582dad.33
	for <qemu-devel@nongnu.org>; Wed, 01 Feb 2012 05:19:23 -0800 (PST)
Message-ID: <4F293BD7.4080503@codemonkey.ws>
Date: Wed, 01 Feb 2012 07:19:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1328035553.git.jan.kiszka@siemens.com>	<1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com>	<4F285FBA.5050607@codemonkey.ws>
	<4F2861F4.1000604@web.de>	<4F292ED1.3060901@redhat.com>
	<4F293361.2000300@siemens.com>
In-Reply-To: <4F293361.2000300@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM
 reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>

On 02/01/2012 06:43 AM, Jan Kiszka wrote:
> On 2012-02-01 13:23, Paolo Bonzini wrote:
>> On 01/31/2012 10:49 PM, Jan Kiszka wrote:
>>>>   Just make the methods that you want to override virtual with the default
>>>>   implementation and then make a KVMPIT that inherits from the PIT and
>>>>   then overrides whatever virtual functions it needs to.
>>>
>>> That doesn't sound like the proper design for this purpose. Rather, we
>>> have an abstract base class that both implementations are derived from.
>>
>> Absolutely!
>>
>>> If I'm not using QOM properly to achieve this, please tell me.
>>
>> It looks good, besides the need to rebase to Anthony's "part 3" changes.
>
> Given that this part is not upstream and that the relevant conversion is
> scripted, I would leave this to Anthony so far. Or what is the schedule?

I haven't run through regression testing yet so YMMV but the latest series is at:

https://github.com/aliguori/qemu/tree/qom-upstream.13

Regards,

Anthony Liguori

>
> Jan
>