qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3] optionroms: Silence intermediate file removal
Date: Wed, 01 Feb 2012 16:11:14 -0600	[thread overview]
Message-ID: <4F29B882.4040209@codemonkey.ws> (raw)
In-Reply-To: <4F267095.6010207@siemens.com>

On 01/30/2012 04:27 AM, Jan Kiszka wrote:
> The build process of optionroms spits out an "rm ..." line. Moreover, it
> removes all .o files that can be handy for debugging purposes. So
> disable automatic intermediate removal.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>
> Changes in v3:
>   - do not remove intermediate file manually, it breaks parallel build
>
>   pc-bios/optionrom/Makefile |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
> index 51da288..2caf7e6 100644
> --- a/pc-bios/optionrom/Makefile
> +++ b/pc-bios/optionrom/Makefile
> @@ -16,6 +16,9 @@ QEMU_CFLAGS = $(CFLAGS)
>
>   build-all: multiboot.bin linuxboot.bin
>
> +# suppress auto-removal of intermediate files
> +.SECONDARY:
> +
>   %.img: %.o
>   	$(call quiet-command,$(LD) -Ttext 0 -e _start -s -o $@ $<,"  Building $(TARGET_DIR)$@")
>

      reply	other threads:[~2012-02-01 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23 18:34 [Qemu-devel] [PATCH] optionroms: Silence intermediate file removal Jan Kiszka
2012-01-27  6:19 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-01-27 10:22 ` [Qemu-devel] " Andreas Färber
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2012-01-27 13:24   ` Andreas Färber
2012-01-30 10:27   ` [Qemu-devel] [PATCH v3] " Jan Kiszka
2012-02-01 22:11     ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F29B882.4040209@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=afaerber@suse.de \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).