From: Anthony Liguori <anthony@codemonkey.ws>
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [Qemu-devel] [PATCH v3 resend] ./configure: request pkg-config to provide private libs when static linking
Date: Wed, 01 Feb 2012 16:11:58 -0600 [thread overview]
Message-ID: <4F29B8AE.4090509@codemonkey.ws> (raw)
In-Reply-To: <1328036625-32251-1-git-send-email-slyfox@inbox.ru>
On 01/31/2012 01:03 PM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich<slyfox@gentoo.org>
>
> Added wrapper around pkg-config to allow:
> - safe options injection via ${QEMU_PKG_CONFIG_FLAGS}
> - spaces in path to pkg-config
>
> Signed-off-by: Sergei Trofimovich<slyfox@gentoo.org>
> CC: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> configure | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index f69e08f..8fd5404 100755
> --- a/configure
> +++ b/configure
> @@ -234,7 +234,11 @@ ld="${LD-${cross_prefix}ld}"
> libtool="${LIBTOOL-${cross_prefix}libtool}"
> strip="${STRIP-${cross_prefix}strip}"
> windres="${WINDRES-${cross_prefix}windres}"
> -pkg_config="${PKG_CONFIG-${cross_prefix}pkg-config}"
> +pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
> +query_pkg_config() {
> + "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@"
> +}
> +pkg_config=query_pkg_config
> sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
>
> # default flags for all hosts
> @@ -553,6 +557,7 @@ for opt do
> --static)
> static="yes"
> LDFLAGS="-static $LDFLAGS"
> + QEMU_PKG_CONFIG_FLAGS="--static $QEMU_PKG_CONFIG_FLAGS"
> ;;
> --mandir=*) mandir="$optarg"
> ;;
> @@ -1449,8 +1454,8 @@ fi
> ##########################################
> # pkg-config probe
>
> -if ! has $pkg_config; then
> - echo "Error: pkg-config binary '$pkg_config' not found"
> +if ! has "$pkg_config_exe"; then
> + echo "Error: pkg-config binary '$pkg_config_exe' not found"
> exit 1
> fi
>
prev parent reply other threads:[~2012-02-01 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 19:03 [Qemu-devel] [PATCH v3 resend] ./configure: request pkg-config to provide private libs when static linking Sergei Trofimovich
2012-02-01 22:11 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29B8AE.4090509@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=slyfox@gentoo.org \
--cc=slyfox@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).