From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RsiWR-0005yO-Qv
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 17:19:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RsiWN-0001rc-Qx
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 17:19:23 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:51311)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RsiWN-0001rS-L5
	for qemu-devel@nongnu.org; Wed, 01 Feb 2012 17:19:19 -0500
Received: by dadp14 with SMTP id p14so1619097dad.4
	for <qemu-devel@nongnu.org>; Wed, 01 Feb 2012 14:19:18 -0800 (PST)
Message-ID: <4F29BA62.8070609@codemonkey.ws>
Date: Wed, 01 Feb 2012 16:19:14 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <alpine.LFD.2.02.1201252200070.8940@bbs.intern>	<m3ipjy29fw.fsf@blackfin.pond.sub.org>
	<4F212EC7.3010500@redhat.com>
In-Reply-To: <4F212EC7.3010500@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable
 NIC	option roms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 01/26/2012 04:45 AM, Gerd Hoffmann wrote:
> On 01/26/12 08:45, Markus Armbruster wrote:
>> Gerhard Wiesinger<lists@wiesinger.com>  writes:
>>
>>> Option ROM for network interface cards (NICs) can now explicitly disabled
>>> with romfile=disabled (or romfile=no or romfile=none) parameter.
>>> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work.
>>> This patch disables Option ROMs for iPXE for alls supported NICs
>>> (hotplugable and non hotplugable).
>>
>> And now filenames "disabled", "no" and "none" don't work.
>>
>> Any way to fix "romfile="?
>
> Sure.

Care to submit as a proper patch?

Regards,

Anthony Liguori

>
> cheers,
>    Gerd