From: Evgeny Voevodin <e.voevodin@samsung.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com
Subject: Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.
Date: Thu, 02 Feb 2012 09:20:18 +0400 [thread overview]
Message-ID: <4F2A1D12.8020008@samsung.com> (raw)
In-Reply-To: <4F2990CE.2030706@suse.de>
On 02/01/2012 11:21 PM, Andreas Färber wrote:
>
>> +static const VMStateDescription VMState_Exynos4210IRQGate = {
> Not CamelCase ;)
>
> But seriously, I really think review makes more sense when the patches
> can actually be applied unmodified.
Out patches could be applied to current master without modification ;)
> Since Peter, as I understood, does
> not have a kernel to test these machines himself,
Anyone can get the kernel from kernel.org. It works with default
configuration
as mentioned in the cover letter.
> this will need to be
> rebased by you guys - either onto Anthony's designated qom-upstream.X
> branch or wait til next week for the patches to arrive in master.
>
> Regards,
> Andreas
>
Thanks for the remarks. It seems that our patches will not be applied until
Anthony's patches come to upstream. If so, we will fix CamelCases and
spaces, rebase and
produce v12.
Could someone, please, advise a better/faster way: wait until Anthony's
patches
are landed into master or rebase on his branch? I'm afraid that till
these patches are not in
the master we could have to rebase many times if qom-upstream.X branch
is used because we
do not actually know which version will be last.
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
next prev parent reply other threads:[~2012-02-02 5:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 7:38 [Qemu-devel] [PATCH v11 0/9] ARM: Samsung Exynos4210-based boards support Evgeny Voevodin
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support Evgeny Voevodin
2012-02-01 16:13 ` Peter Maydell
2012-02-01 19:21 ` Andreas Färber
2012-02-02 5:20 ` Evgeny Voevodin [this message]
2012-02-02 7:52 ` Evgeny Voevodin
2012-02-02 6:16 ` Evgeny Voevodin
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 2/9] ARM: Samsung exynos4210-based boards emulation Evgeny Voevodin
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 3/9] ARM: exynos4210: UART support Evgeny Voevodin
2012-02-01 15:40 ` Peter Maydell
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 4/9] ARM: exynos4210: PWM support Evgeny Voevodin
2012-01-31 8:31 ` Evgeny Voevodin
2012-02-01 13:43 ` Peter Maydell
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 5/9] ARM: exynos4210: basic Power Management Unit implementation Evgeny Voevodin
2012-02-01 16:21 ` Peter Maydell
2012-02-02 6:06 ` Mitsyanko Igor
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 6/9] ARM: exynos4210: MCT support Evgeny Voevodin
2012-01-31 8:32 ` Evgeny Voevodin
2012-02-01 13:43 ` Peter Maydell
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 7/9] hw/lan9118: Add basic 16-bit mode support Evgeny Voevodin
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 8/9] hw/exynos4210.c: Add LAN support for SMDKC210 Evgeny Voevodin
2012-01-30 7:38 ` [Qemu-devel] [PATCH v11 9/9] Exynos4210: added display controller implementation Evgeny Voevodin
2012-01-31 8:33 ` Evgeny Voevodin
2012-02-01 13:44 ` Peter Maydell
2012-02-02 18:43 ` [Qemu-devel] [PATCH v11 0/9] ARM: Samsung Exynos4210-based boards support Peter Maydell
2012-02-03 5:24 ` Evgeny Voevodin
2012-02-03 6:29 ` Evgeny Voevodin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2A1D12.8020008@samsung.com \
--to=e.voevodin@samsung.com \
--cc=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).