From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsp5z-00058f-W9 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 00:20:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rsp5y-0000UN-AK for qemu-devel@nongnu.org; Thu, 02 Feb 2012 00:20:31 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:33522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsp5y-0000Te-5y for qemu-devel@nongnu.org; Thu, 02 Feb 2012 00:20:30 -0500 Received: from euspt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LYR00D2N2U1X9@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 02 Feb 2012 05:20:25 +0000 (GMT) Received: from [106.109.9.191] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LYR002YO2TW3A@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 02 Feb 2012 05:20:25 +0000 (GMT) Date: Thu, 02 Feb 2012 09:20:18 +0400 From: Evgeny Voevodin In-reply-to: <4F2990CE.2030706@suse.de> Message-id: <4F2A1D12.8020008@samsung.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-15 Content-transfer-encoding: QUOTED-PRINTABLE References: <1327909117-4542-1-git-send-email-e.voevodin@samsung.com> <1327909117-4542-2-git-send-email-e.voevodin@samsung.com> <4F2990CE.2030706@suse.de> Subject: Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Peter Maydell , qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com On 02/01/2012 11:21 PM, Andreas F=E4rber wrote: > >> +static const VMStateDescription VMState_Exynos4210IRQGate =3D { > Not CamelCase ;) > > But seriously, I really think review makes more sense when the patc= hes > can actually be applied unmodified. Out patches could be applied to current master without modification ;= ) > Since Peter, as I understood, does > not have a kernel to test these machines himself, Anyone can get the kernel from kernel.org. It works with default=20 configuration as mentioned in the cover letter. > this will need to be > rebased by you guys - either onto Anthony's designated qom-upstream= .X > branch or wait til next week for the patches to arrive in master. > > Regards, > Andreas > Thanks for the remarks. It seems that our patches will not be applied= until Anthony's patches come to upstream. If so, we will fix CamelCases and= =20 spaces, rebase and produce v12. Could someone, please, advise a better/faster way: wait until Anthony= 's=20 patches are landed into master or rebase on his branch? I'm afraid that till= =20 these patches are not in the master we could have to rebase many times if qom-upstream.X branc= h=20 is used because we do not actually know which version will be last. --=20 Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com