From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt0TP-0007jx-EL for qemu-devel@nongnu.org; Thu, 02 Feb 2012 12:29:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rt0TN-0003Kw-V5 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 12:29:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt0TN-0003Kl-OU for qemu-devel@nongnu.org; Thu, 02 Feb 2012 12:29:25 -0500 Message-ID: <4F2AC7F0.7080204@redhat.com> Date: Thu, 02 Feb 2012 18:29:20 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-2-git-send-email-pbonzini@redhat.com> <4F2AC1D2.9090606@codemonkey.ws> In-Reply-To: <4F2AC1D2.9090606@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 02/02/2012 06:03 PM, Anthony Liguori wrote: >> > > Is this still needed with qom-upstream.14? I fixed a bug on .14 that > involved child properties that was making device-del sometimes fail. Not sure, I tried with .13 but, from the look of it, it should still be there. Regarding the .13->.14 diff: - you need QTAILQ_FOREACH_SAFE in object_property_del_child. - you need to check for the existence of the non-aliased name when accessing the alias table, because s390 does not have PCI. > If it is, what's your test case? I check that the device disappears from "info qtree". I check with gdb that after object_unparent the refcount is zero. Paolo