From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug
Date: Thu, 02 Feb 2012 13:01:58 -0600 [thread overview]
Message-ID: <4F2ADDA6.4070603@codemonkey.ws> (raw)
In-Reply-To: <4F2AC7F0.7080204@redhat.com>
On 02/02/2012 11:29 AM, Paolo Bonzini wrote:
> On 02/02/2012 06:03 PM, Anthony Liguori wrote:
>>>
>>
>> Is this still needed with qom-upstream.14? I fixed a bug on .14 that
>> involved child properties that was making device-del sometimes fail.
>
> Not sure, I tried with .13 but, from the look of it, it should still be there.
> Regarding the .13->.14 diff:
>
> - you need QTAILQ_FOREACH_SAFE in object_property_del_child.
Ack.
>
> - you need to check for the existence of the non-aliased name when accessing the
> alias table, because s390 does not have PCI.
I don't think that's the right strategy as it means that s390 only works if we
don't include the PCI objects in the build (regardless of whether it uses PCI).
This would be defeated if/when we move to having all device objects in a
single shared library used by all of the qemu executables.
I'd prefer to just drop the aliases for s390. I don't see a lot of value in it
and I don't think there are tons of s390 users that will be affected.
>
>> If it is, what's your test case?
>
> I check that the device disappears from "info qtree". I check with gdb that
> after object_unparent the refcount is zero.
Ah, okay, I'll look at this more closely. Thanks.
Regards,
Anthony Liguori
>
> Paolo
>
next prev parent reply other threads:[~2012-02-02 19:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:45 [Qemu-devel] [PATCH 00/16] access qdev properties via QOM Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug Paolo Bonzini
2012-02-02 17:03 ` Anthony Liguori
2012-02-02 17:29 ` Paolo Bonzini
2012-02-02 19:01 ` Anthony Liguori [this message]
2012-02-02 19:07 ` Alexander Graf
2012-02-02 20:03 ` Anthony Liguori
2012-02-02 20:31 ` Alexander Graf
2012-02-03 16:37 ` Anthony Liguori
2012-02-03 16:57 ` Alexander Graf
2012-02-03 17:12 ` Anthony Liguori
2012-02-03 14:27 ` Anthony Liguori
2012-02-04 0:27 ` Paolo Bonzini
2012-02-04 3:03 ` Anthony Liguori
2012-02-04 6:51 ` Paolo Bonzini
2012-02-04 17:13 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 02/16] qom: store object with correct type in interface links Paolo Bonzini
2012-02-02 17:05 ` Anthony Liguori
2012-02-03 12:10 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 03/16] qom: do not include qdev header file Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers Paolo Bonzini
2012-02-02 19:06 ` Anthony Liguori
2012-02-02 19:21 ` Andreas Färber
2012-02-02 20:58 ` Anthony Liguori
2012-02-02 19:24 ` Paolo Bonzini
2012-02-02 19:29 ` Paolo Bonzini
2012-02-02 20:01 ` Anthony Liguori
2012-02-02 19:36 ` Anthony Liguori
2012-02-02 20:08 ` Paolo Bonzini
2012-02-02 20:59 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 05/16] qom: add property get/set wrappers for C types Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 06/16] qdev: remove direct calls to print/parse Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 07/16] qdev: allow reusing get/set for legacy property Paolo Bonzini
2012-02-02 22:38 ` Andreas Färber
2012-02-03 8:11 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 08/16] qdev: remove parse method for string properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 09/16] qdev: remove parse/print methods for mac properties Paolo Bonzini
2012-02-02 20:05 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer Paolo Bonzini
2012-02-02 20:07 ` Anthony Liguori
2012-02-02 20:19 ` Paolo Bonzini
2012-02-03 14:14 ` Anthony Liguori
2012-02-04 0:21 ` Paolo Bonzini
2012-02-04 0:43 ` Paolo Bonzini
2012-02-04 3:00 ` Anthony Liguori
2012-02-04 6:42 ` Paolo Bonzini
2012-02-04 7:13 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 11/16] qdev: remove parse/print methods for pointer properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 12/16] qdev: let QOM free properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 13/16] qdev: fix off-by-one Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 14/16] qdev: access properties via QOM Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 15/16] qdev: inline qdev_prop_set into qdev_prop_set_ptr Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 16/16] qdev: initialize properties via QOM Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2ADDA6.4070603@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).