From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt3jt-0001XI-CS for qemu-devel@nongnu.org; Thu, 02 Feb 2012 15:58:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rt3js-0006Fj-E2 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 15:58:41 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:42340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt3js-0006Ff-67 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 15:58:40 -0500 Received: by dadp14 with SMTP id p14so2743121dad.4 for ; Thu, 02 Feb 2012 12:58:39 -0800 (PST) Message-ID: <4F2AF8FA.4060000@codemonkey.ws> Date: Thu, 02 Feb 2012 14:58:34 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-5-git-send-email-pbonzini@redhat.com> <4F2ADEB0.6090308@codemonkey.ws> <4F2AE250.9020808@suse.de> In-Reply-To: <4F2AE250.9020808@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org On 02/02/2012 01:21 PM, Andreas Färber wrote: > Am 02.02.2012 20:06, schrieb Anthony Liguori: >> On 02/02/2012 10:45 AM, Paolo Bonzini wrote: >>> Move the creation of QmpInputVisitor and QmpOutputVisitor from >>> qmp.c to qom/object.c, since it's the only practical way to access >>> object properties. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> include/qemu/object.h | 24 ++++++++++++++++++++++++ >>> qmp.c | 17 ++--------------- >>> qom/object.c | 29 +++++++++++++++++++++++++++++ >>> 3 files changed, 55 insertions(+), 15 deletions(-) >> >> I don't want object.h to have a dependency on QObject. We need to phase >> out QObject. > > We did get that dependency though by your move of the property code to > object.c. As you will see shortly, we now need qobject-obj-y and > qapi-obj-y plus some stubs to make the user emulators compile with QOM. > That's an implementation detail of Error, that's not because QObject is used anywhere in QOM. Regards, Anthony Liguori > Andreas >