From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtHyq-00055p-6n for qemu-devel@nongnu.org; Fri, 03 Feb 2012 07:11:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtHyk-0001QV-Eq for qemu-devel@nongnu.org; Fri, 03 Feb 2012 07:11:04 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:51233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtHyk-0001QM-8i for qemu-devel@nongnu.org; Fri, 03 Feb 2012 07:10:58 -0500 Received: by pbaa11 with SMTP id a11so3706714pba.4 for ; Fri, 03 Feb 2012 04:10:57 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F2BCECA.5040704@redhat.com> Date: Fri, 03 Feb 2012 13:10:50 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-3-git-send-email-pbonzini@redhat.com> <4F2AC260.50709@codemonkey.ws> In-Reply-To: <4F2AC260.50709@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/16] qom: store object with correct type in interface links List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 02/02/2012 06:05 PM, Anthony Liguori wrote: > On 02/02/2012 10:45 AM, Paolo Bonzini wrote: >> When a link property's type is an interface, the code expects the >> implementation object (not the parent object) to be stored in the >> variable. The parent object does not contain the right vtable. >> >> Signed-off-by: Paolo Bonzini >> --- >> qom/object.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/qom/object.c b/qom/object.c >> index cd517f6..de6484d 100644 >> --- a/qom/object.c >> +++ b/qom/object.c >> @@ -749,7 +749,8 @@ static void object_set_link_property(Object *obj, >> Visitor *v, void *opaque, >> target_type = g_strdup(&type[5]); >> target_type[strlen(target_type) - 2] = 0; >> >> - if (object_dynamic_cast(target, target_type)) { >> + target = object_dynamic_cast(target, target_type); >> + if (target) { >> object_ref(target); >> *child = target; > > Very good catch. But when we implement type-based search for partial paths it will be fixed automatically (because object_resolve_path will have to do a dynamic cast on its own). Let's do that instead. I'll rebase the patch while travelling, since I have to convert LostTickPolicy as well. Let's look at this after the weekend. Paolo