From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtJud-0006pq-Vo for qemu-devel@nongnu.org; Fri, 03 Feb 2012 09:14:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtJuZ-0002Nz-RS for qemu-devel@nongnu.org; Fri, 03 Feb 2012 09:14:51 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:40379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtJuZ-0002Np-Ib for qemu-devel@nongnu.org; Fri, 03 Feb 2012 09:14:47 -0500 Received: by pbaa11 with SMTP id a11so3814945pba.4 for ; Fri, 03 Feb 2012 06:14:46 -0800 (PST) Message-ID: <4F2BEBD1.3040908@codemonkey.ws> Date: Fri, 03 Feb 2012 08:14:41 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-11-git-send-email-pbonzini@redhat.com> <4F2AECE6.1060602@codemonkey.ws> <4F2AEFE7.9020901@redhat.com> In-Reply-To: <4F2AEFE7.9020901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 02/02/2012 02:19 PM, Paolo Bonzini wrote: > On 02/02/2012 09:07 PM, Anthony Liguori wrote: >>> >>> Signed-off-by: Paolo Bonzini >> >> Isn't this a compatibility breaker? >> >> Won't this break libvirt's usage of -device addr=0.2 ? > > Nope, the legacy property still keeps the dd.f format. This is only for QOM (and > internal use by qdev). Ah, I forgot we duplicate the properties here. Since there is now a programmatic mapping between legacy properties types and non-legacy property types, could we remove the legacy properties that now have well behaved types and add some code to device_add to maintain compatibility? Regards, Anthony Liguori > Paolo >