From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RtTNS-0008F6-Al
	for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:21:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RtTNR-0000rK-8n
	for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:21:14 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:55177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RtTNR-0000r3-0c
	for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:21:13 -0500
Received: by wgbdr12 with SMTP id dr12so4300234wgb.10
	for <qemu-devel@nongnu.org>; Fri, 03 Feb 2012 16:21:11 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F2C79F0.9090904@redhat.com>
Date: Sat, 04 Feb 2012 01:21:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com>	<1328201142-26145-11-git-send-email-pbonzini@redhat.com>	<4F2AECE6.1060602@codemonkey.ws>
	<4F2AEFE7.9020901@redhat.com> <4F2BEBD1.3040908@codemonkey.ws>
In-Reply-To: <4F2BEBD1.3040908@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci
 address property accept an integer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 02/03/2012 03:14 PM, Anthony Liguori wrote:
>>>
>>
>> Nope, the legacy property still keeps the dd.f format. This is only
>> for QOM (and
>> internal use by qdev).
>
> Ah, I forgot we duplicate the properties here.
>
> Since there is now a programmatic mapping between legacy properties
> types and non-legacy property types, could we remove the legacy
> properties that now have well behaved types and add some code to
> device_add to maintain compatibility?

I'm not sure... we would trade removal of an ugly concept (the legacy 
properties) with addition of a layering violation (poking into the 
DeviceState subclasses).

We could hide them in qom-list/qom-get, but I'm not sure this would buy 
us anything, either.

Paolo