From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtVs3-0000Tc-Af for qemu-devel@nongnu.org; Fri, 03 Feb 2012 22:01:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtVs2-0005qY-70 for qemu-devel@nongnu.org; Fri, 03 Feb 2012 22:00:59 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:36815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtVs1-0005qS-Ty for qemu-devel@nongnu.org; Fri, 03 Feb 2012 22:00:58 -0500 Received: by dadp14 with SMTP id p14so4154195dad.4 for ; Fri, 03 Feb 2012 19:00:56 -0800 (PST) Message-ID: <4F2C9F64.9030402@codemonkey.ws> Date: Fri, 03 Feb 2012 21:00:52 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-11-git-send-email-pbonzini@redhat.com> <4F2AECE6.1060602@codemonkey.ws> <4F2AEFE7.9020901@redhat.com> <4F2BEBD1.3040908@codemonkey.ws> <4F2C79F0.9090904@redhat.com> <4F2C7F3A.50306@redhat.com> In-Reply-To: <4F2C7F3A.50306@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 02/03/2012 06:43 PM, Paolo Bonzini wrote: > On 02/04/2012 01:21 AM, Paolo Bonzini wrote: >> I'm not sure... we would trade removal of an ugly concept (the legacy >> properties) with addition of a layering violation (poking into the >> DeviceState subclasses). > > The main problem here is that you said no to a hierarchy of property classes. > This is what would be good here: being able to say "does this property have > legacy print/parse methods?" and call them if available from device_add. > > So, you can choose your poison. :) For now I think the idea in this patch series > is good enough for its purpose (which is to actually _use_ QOM), Yeah, I was just thinking out loud. My plan is to pull your series into my qom-rebase branch. The last few commits on https://github.com/aliguori/qemu/tree/qom-rebase.12 have a variant visitor and accessors that use it. Regards, Anthony Liguori > we can tweak > the design and really eliminate the legacy properties later. I don't mind going > through multiple iterations as long as the state after each iteration is clearly > better than before. > f > Paolo