From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtZoT-0004UT-5w for qemu-devel@nongnu.org; Sat, 04 Feb 2012 02:13:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtZoS-0005RA-9V for qemu-devel@nongnu.org; Sat, 04 Feb 2012 02:13:33 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:65005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtZoS-0005R5-40 for qemu-devel@nongnu.org; Sat, 04 Feb 2012 02:13:32 -0500 Received: by werh12 with SMTP id h12so3822946wer.4 for ; Fri, 03 Feb 2012 23:13:30 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F2CDA8C.9010302@redhat.com> Date: Sat, 04 Feb 2012 08:13:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-11-git-send-email-pbonzini@redhat.com> <4F2AECE6.1060602@codemonkey.ws> <4F2AEFE7.9020901@redhat.com> <4F2BEBD1.3040908@codemonkey.ws> <4F2C79F0.9090904@redhat.com> <4F2C7F3A.50306@redhat.com> <4F2C9F64.9030402@codemonkey.ws> <4F2CD370.7040709@redhat.com> In-Reply-To: <4F2CD370.7040709@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org On 02/04/2012 07:42 AM, Paolo Bonzini wrote: > Ok, I'll cherry-pick from there and send out an updated patch series > later today. ... that won't work unfortunately. Enums are broken (not your fault really, I sent this before losttickpolicy went in); I really dislike having a single object that can magically act both as input and output visitor; and there is no documentation in the header for the new functions. I'll stick with the QObject version for now, but move it to a separate file. Paolo