From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rteep-0005Ew-MP for qemu-devel@nongnu.org; Sat, 04 Feb 2012 07:23:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rteen-0005X4-NA for qemu-devel@nongnu.org; Sat, 04 Feb 2012 07:23:55 -0500 Message-ID: <4F2D2352.80204@web.de> Date: Sat, 04 Feb 2012 13:23:46 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4F2BCCBD.8050009@siemens.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA935425AE780C261F8209223" Subject: Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-trivial , qemu-devel , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA935425AE780C261F8209223 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-02-04 13:12, Blue Swirl wrote: > On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote= : >> Helpful to understand guest configurations of things like the i440FX's= >> PAM. >> >> Signed-off-by: Jan Kiszka >> --- >> memory.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/memory.c b/memory.c >> index ee4c98a..ea4adda 100644 >> --- a/memory.c >> +++ b/memory.c >> @@ -1608,23 +1608,25 @@ static void mtree_print_mr(fprintf_function mo= n_printf, void *f, >> ml->printed =3D false; >> QTAILQ_INSERT_TAIL(alias_print_queue, ml, queue); >> } >> - mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d): = alias %s @%s " >> + mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %= s): alias %s @%s " >> TARGET_FMT_plx "-" TARGET_FMT_plx "\n", >> base + mr->addr, >> base + mr->addr >> + (target_phys_addr_t)int128_get64(mr->size) - 1, >> mr->priority, >> + mr->readonly ? "RO" : "RW", >=20 > I think the reserved regions which are unreadable and unwritable > should be shown as well. Then the output should be a combination of > 'R', 'W' or neither ('-'). Reserved regions are in the hand of some other device model (so far only the KVM kernel). That says nothing about their R/W property. If we ever have a reserved region that is not writable, the owner could still set the corresponding flag for documentation purposes. Jan --------------enigA935425AE780C261F8209223 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8tI1YACgkQitSsb3rl5xQAZACeII9oKsOHxcjOKH2ISRLFJ1GZ neYAn3wUHWjjapIdeB8HS/sFkp+qvJyq =lSgJ -----END PGP SIGNATURE----- --------------enigA935425AE780C261F8209223--