* [Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again
@ 2012-02-04 14:58 Jan Kiszka
2012-02-11 11:08 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2012-02-04 14:58 UTC (permalink / raw)
To: qemu-devel, Blue Swirl
The conversion to memory regions broke lazy ROMD switching by forgetting
to update the rom_mode state variable.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/pflash_cfi02.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
index a9e88b9..2ca0fd4 100644
--- a/hw/pflash_cfi02.c
+++ b/hw/pflash_cfi02.c
@@ -102,6 +102,7 @@ static void pflash_setup_mappings(pflash_t *pfl)
static void pflash_register_memory(pflash_t *pfl, int rom_mode)
{
memory_region_rom_device_set_readable(&pfl->orig_mem, rom_mode);
+ pfl->rom_mode = rom_mode;
}
static void pflash_timer (void *opaque)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again
2012-02-04 14:58 [Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again Jan Kiszka
@ 2012-02-11 11:08 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2012-02-11 11:08 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
Thanks, applied.
On Sat, Feb 4, 2012 at 14:58, Jan Kiszka <jan.kiszka@web.de> wrote:
> The conversion to memory regions broke lazy ROMD switching by forgetting
> to update the rom_mode state variable.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/pflash_cfi02.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
> index a9e88b9..2ca0fd4 100644
> --- a/hw/pflash_cfi02.c
> +++ b/hw/pflash_cfi02.c
> @@ -102,6 +102,7 @@ static void pflash_setup_mappings(pflash_t *pfl)
> static void pflash_register_memory(pflash_t *pfl, int rom_mode)
> {
> memory_region_rom_device_set_readable(&pfl->orig_mem, rom_mode);
> + pfl->rom_mode = rom_mode;
> }
>
> static void pflash_timer (void *opaque)
> --
> 1.7.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-11 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-04 14:58 [Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again Jan Kiszka
2012-02-11 11:08 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).