From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuPNP-0005b5-P2 for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:17:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuPNK-0008UD-4C for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:17:03 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:39703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuPNJ-0008U7-P8 for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:16:58 -0500 Received: by pbaa11 with SMTP id a11so6779028pba.4 for ; Mon, 06 Feb 2012 06:16:57 -0800 (PST) Message-ID: <4F2FE0D5.9020407@codemonkey.ws> Date: Mon, 06 Feb 2012 08:16:53 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> <1328342577-25732-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1328342577-25732-7-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 02/04/2012 02:02 AM, Paolo Bonzini wrote: > Move the creation of QmpInputVisitor and QmpOutputVisitor from > qmp.c to qom/object.c, since it's the only practical way to access > object properties. > > Signed-off-by: Paolo Bonzini Reluctantly-Reviewed-by: Anthony Liguori As long as we keep this isolated such that it's easy to remove. At some point, we need to remove all usage of QObject in the tree and replace it with GVariant. Regards, Anthony Liguori