From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuPXQ-0002YJ-QN for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:27:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuPXK-0001nA-Rt for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:27:24 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuPXK-0001n5-JQ for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:27:18 -0500 Received: by dadp14 with SMTP id p14so6484516dad.4 for ; Mon, 06 Feb 2012 06:27:17 -0800 (PST) Message-ID: <4F2FE342.7040906@codemonkey.ws> Date: Mon, 06 Feb 2012 08:27:14 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> <1328342577-25732-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1328342577-25732-13-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 12/27] qom: add property get/set wrappers for links List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 02/04/2012 02:02 AM, Paolo Bonzini wrote: > These can set a link to any object, as long as it is included in > the composition tree. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 24 ++++++++++++++++++++++++ > qom/object.c | 25 +++++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 0 deletions(-) > > diff --git a/include/qemu/object.h b/include/qemu/object.h > index 4ec7942..910b767 100644 > --- a/include/qemu/object.h > +++ b/include/qemu/object.h > @@ -658,6 +658,30 @@ char *object_property_get_str(Object *obj, const char *name, > struct Error **errp); > > /** > + * object_property_set_link: > + * @value: the value to be written to the property > + * @name: the name of the property > + * @errp: returns an error if this function fails > + * > + * Writes an object's canonical path to a property. > + */ > +void object_property_set_link(Object *obj, Object *value, > + const char *name, struct Error **errp); > + > +/** > + * object_property_get_link: > + * @obj: the object > + * @name: the name of the property > + * @errp: returns an error if this function fails > + * > + * Returns: the value of the property, resolved from a path to an Object, > + * or NULL if an error occurs (including when the property value is not a > + * string or not a valid object path). > + */ > +Object *object_property_get_link(Object *obj, const char *name, > + struct Error **errp); > + > +/** > * object_property_set_bool: > * @value: the value to be written to the property > * @name: the name of the property > diff --git a/qom/object.c b/qom/object.c > index e8418bc..b3cff50 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -710,6 +710,30 @@ char *object_property_get_str(Object *obj, const char *name, > return retval; > } > > +void object_property_set_link(Object *obj, Object *value, > + const char *name, Error **errp) > +{ > + object_property_set_str(obj, object_get_canonical_path(value), > + name, errp); > +} We could fall back to setting the link directly via the property opaque, but I guess that might let us get lazy about filling in the composition tree. Regards, Anthony Liguori > + > +Object *object_property_get_link(Object *obj, const char *name, > + Error **errp) > +{ > + char *str = object_property_get_str(obj, name, errp); > + Object *target = NULL; > + > + if (str&& *str) { > + target = object_resolve_path(str, NULL); > + if (!target) { > + error_set(errp, QERR_DEVICE_NOT_FOUND, str); > + } > + } > + > + g_free(str); > + return target; > +} > + > void object_property_set_bool(Object *obj, bool value, > const char *name, Error **errp) > {