From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37702)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPba-0005fT-44
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:31:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPbU-0003EF-Dz
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:31:42 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:37240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPbU-0003E8-83
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:31:36 -0500
Received: by dadp14 with SMTP id p14so6488594dad.4
	for <qemu-devel@nongnu.org>; Mon, 06 Feb 2012 06:31:35 -0800 (PST)
Message-ID: <4F2FE443.3030900@codemonkey.ws>
Date: Mon, 06 Feb 2012 08:31:31 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com>
	<1328342577-25732-16-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1328342577-25732-16-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for
 string properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/04/2012 02:02 AM, Paolo Bonzini wrote:
> We need the print method to put double quotes, but parsing is not special.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   hw/qdev-properties.c |   11 -----------
>   1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 5e19ec8..1fc77b5 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -510,16 +510,6 @@ PropertyInfo qdev_prop_hex64 = {
>
>   /* --- string --- */
>
> -static int parse_string(DeviceState *dev, Property *prop, const char *str)
> -{
> -    char **ptr = qdev_get_prop_ptr(dev, prop);
> -
> -    if (*ptr)
> -        g_free(*ptr);
> -    *ptr = g_strdup(str);
> -    return 0;
> -}
> -
>   static void free_string(DeviceState *dev, Property *prop)
>   {
>       g_free(*(char **)qdev_get_prop_ptr(dev, prop));
> @@ -581,7 +571,6 @@ PropertyInfo qdev_prop_string = {
>       .name  = "string",
>       .type  = PROP_TYPE_STRING,
>       .size  = sizeof(char*),
> -    .parse = parse_string,
>       .print = print_string,
>       .free  = free_string,
>       .get   = get_string,