From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPfm-0003KW-Hf
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:36:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPfg-0004OY-8E
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:36:02 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:45232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RuPfg-0004OF-2x
	for qemu-devel@nongnu.org; Mon, 06 Feb 2012 09:35:56 -0500
Received: by pbaa11 with SMTP id a11so6796562pba.4
	for <qemu-devel@nongnu.org>; Mon, 06 Feb 2012 06:35:55 -0800 (PST)
Message-ID: <4F2FE547.40508@codemonkey.ws>
Date: Mon, 06 Feb 2012 08:35:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com>
	<1328342577-25732-22-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1328342577-25732-22-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/04/2012 02:02 AM, Paolo Bonzini wrote:
> Integer properties did not work.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   hw/qdev-properties.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index d69a987..debb37f 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque,
>           error_propagate(errp, local_err);
>           return;
>       }
> -    if (value>  prop->info->min&&  value<= prop->info->max) {
> +    if (value>= prop->info->min&&  value<= prop->info->max) {
>           *ptr = value;
>       } else {
>           error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
> @@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque,
>           error_propagate(errp, local_err);
>           return;
>       }
> -    if (value>  prop->info->min&&  value<= prop->info->max) {
> +    if (value>= prop->info->min&&  value<= prop->info->max) {
>           *ptr = value;
>       } else {
>           error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
> @@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque,
>           error_propagate(errp, local_err);
>           return;
>       }
> -    if (value>  prop->info->min&&  value<= prop->info->max) {
> +    if (value>= prop->info->min&&  value<= prop->info->max) {
>           *ptr = value;
>       } else {
>           error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,