From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuU1a-0001nW-UP for qemu-devel@nongnu.org; Mon, 06 Feb 2012 14:14:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuU1Y-000864-GW for qemu-devel@nongnu.org; Mon, 06 Feb 2012 14:14:50 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:63167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuU1Y-00085l-7N for qemu-devel@nongnu.org; Mon, 06 Feb 2012 14:14:48 -0500 Received: by dadp14 with SMTP id p14so6751648dad.4 for ; Mon, 06 Feb 2012 11:14:47 -0800 (PST) Message-ID: <4F3026A3.4060307@codemonkey.ws> Date: Mon, 06 Feb 2012 13:14:43 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328237992-14953-1-git-send-email-afaerber@suse.de> <1328237992-14953-2-git-send-email-afaerber@suse.de> In-Reply-To: <1328237992-14953-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 01/21] qom: Register QOM infrastructure early List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org On 02/02/2012 08:59 PM, Andreas Färber wrote: > QOM TYPE_INTERFACE was registered with device_init(), whose > constructors are executed rather late in vl.c's main(). > > Rename the module init type from DEVICE to QOM and call it very early > so that QOM can safely be used for machines and CPUs. > > device_init() is left for legacy types. New ones should use type_init(). There are no legacy device_init users. Everything can (and should) be converted to type_init() and MODULE_INIT_QOM can be invoked very early. Regards, Anthony Liguori