From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruh6T-0007SQ-7O for qemu-devel@nongnu.org; Tue, 07 Feb 2012 04:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ruh6Q-0002ns-NG for qemu-devel@nongnu.org; Tue, 07 Feb 2012 04:12:45 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:65105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruh6Q-0002ne-CW for qemu-devel@nongnu.org; Tue, 07 Feb 2012 04:12:42 -0500 Received: by pbaa11 with SMTP id a11so7689725pba.4 for ; Tue, 07 Feb 2012 01:12:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F30EB02.6080605@redhat.com> Date: Tue, 07 Feb 2012 10:12:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> <1328342577-25732-7-git-send-email-pbonzini@redhat.com> <4F2FE0D5.9020407@codemonkey.ws> In-Reply-To: <4F2FE0D5.9020407@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 02/06/2012 03:16 PM, Anthony Liguori wrote: > >> Move the creation of QmpInputVisitor and QmpOutputVisitor from >> qmp.c to qom/object.c, since it's the only practical way to access >> object properties. >> >> Signed-off-by: Paolo Bonzini > > Reluctantly-Reviewed-by: Anthony Liguori Fair enough, thanks very much. :) > As long as we keep this isolated such that it's easy to remove. At some > point, we need to remove all usage of QObject in the tree and replace it > with GVariant. Agreed, we'll revisit after Luiz completes QAPI. Paolo