From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53648)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1Ruk79-0005cL-Rl
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:25:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1Ruk74-0000ob-Bg
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:25:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1Ruk74-0000oR-56
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:25:34 -0500
Message-ID: <4F311839.9030709@redhat.com>
Date: Tue, 07 Feb 2012 14:25:29 +0200
From: Dor Laor <dlaor@redhat.com>
MIME-Version: 1.0
References: <73865e0ce364c40e0eb65ec6b22b819d@mail.gmail.com>
	<4F31153E.9010205@codemonkey.ws>
In-Reply-To: <4F31153E.9010205@codemonkey.ws>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module
Reply-To: dlaor@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Ori Mamluk <omamluk@zerto.com>

On 02/07/2012 02:12 PM, Anthony Liguori wrote:
> Hi,
>
> On 02/07/2012 04:29 AM, Ori Mamluk wrote:
>> Repagent is a new module that allows an external replication system to
>> replicate a volume of a Qemu VM.
>>
>> This RFC patch adds the repagent client module to Qemu.
>
> Please read http://wiki.qemu.org/Contribute/SubmitAPatch
>
> In particular, use a tool like git-send-email and split this patch up
> into more manageable chunks.
>
> Is there an Open Source rehub available? As a project policy, adding
> external APIs specifically for proprietary software is not something
> we're willing to do.
>
> Regards,
>
> Anthony Liguori

In addition, I don't see that the listener thread holds any lock while 
it reads the image. I guess that during that period the guest runs and 
may race w/ this new thread.

About image ID for the replication hub, you can use the VM's pid or VM's 
uuid paired w/ the specific disk uuid

Thanks,
Dor