From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukLg-0001Ah-IU for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:40:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RukLa-0003MG-2j for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:40:40 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:39508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukLZ-0003M6-QM for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:40:33 -0500 Received: by pbaa11 with SMTP id a11so7856127pba.4 for ; Tue, 07 Feb 2012 04:40:32 -0800 (PST) Message-ID: <4F311BBA.8000708@codemonkey.ws> Date: Tue, 07 Feb 2012 06:40:26 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <73865e0ce364c40e0eb65ec6b22b819d@mail.gmail.com> <4F31153E.9010205@codemonkey.ws> <4F311839.9030709@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ori Mamluk Cc: Kevin Wolf , dlaor@redhat.com, qemu-devel@nongnu.org On 02/07/2012 06:30 AM, Ori Mamluk wrote: >> In addition, I don't see that the listener thread holds any lock while > it reads the image. I guess that during that period the guest runs and may > race w/ this new thread. > > Yes - I mentioned that in the patch mail as one of the open issues. Can > you direct me to the lock I need? The function I call from a new thread > context is bdrv_aio_readv. One thing that has me confused about this proposal. Why not just make rehub be an iSCSI target provider and call it a day? Regards, Anthony Liguori > > -----Original Message----- > From: Dor Laor [mailto:dlaor@redhat.com] > Sent: Tuesday, February 07, 2012 2:25 PM > To: Anthony Liguori > Cc: Ori Mamluk; Kevin Wolf; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module > > On 02/07/2012 02:12 PM, Anthony Liguori wrote: >> Hi, >> >> On 02/07/2012 04:29 AM, Ori Mamluk wrote: >>> Repagent is a new module that allows an external replication system >>> to replicate a volume of a Qemu VM. >>> >>> This RFC patch adds the repagent client module to Qemu. >> >> Please read http://wiki.qemu.org/Contribute/SubmitAPatch >> >> In particular, use a tool like git-send-email and split this patch up >> into more manageable chunks. >> >> Is there an Open Source rehub available? As a project policy, adding >> external APIs specifically for proprietary software is not something >> we're willing to do. >> >> Regards, >> >> Anthony Liguori > > In addition, I don't see that the listener thread holds any lock while it > reads the image. I guess that during that period the guest runs and may > race w/ this new thread. > > About image ID for the replication hub, you can use the VM's pid or VM's > uuid paired w/ the specific disk uuid > > Thanks, > Dor >