From: Paolo Bonzini <pbonzini@redhat.com>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042
Date: Tue, 07 Feb 2012 13:54:11 +0100 [thread overview]
Message-ID: <4F311EF3.9080104@redhat.com> (raw)
In-Reply-To: <87wr7yom0x.fsf@elfo.elfo>
On 02/07/2012 01:39 PM, Juan Quintela wrote:
>> > vmmouse = isa_try_create(isa_bus, "vmmouse");
>> > + qdev_init_nofail(&vmmouse->qdev);
>> > + qdev_connect_gpio_out(DEVICE(vmmouse), 0,
>> > + qdev_get_gpio_in(DEVICE(i8042), 0));
> Are you sue that vmmouse is always non-NULL? My understanding is that
> all callers check if is_try_create() return NULL.
>
> Could you clarify?
No, I couldn't. :) You're right.
Paolo
next prev parent reply other threads:[~2012-02-07 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 8:03 [Qemu-devel] [PATCH 0/3] Remove PROP_PTR, part 2/4 Paolo Bonzini
2012-02-04 8:03 ` [Qemu-devel] [PATCH 1/3] smbus: fix writes Paolo Bonzini
2012-02-04 8:03 ` [Qemu-devel] [PATCH 2/3] smbus_eeprom: remove PTR property Paolo Bonzini
2012-02-04 8:03 ` [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042 Paolo Bonzini
2012-02-04 13:03 ` Gerhard Wiesinger
2012-02-04 13:15 ` Paolo Bonzini
2012-02-07 12:39 ` Juan Quintela
2012-02-07 12:54 ` Paolo Bonzini [this message]
2012-02-09 0:48 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F311EF3.9080104@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).