From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukYw-0005Pq-1P for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:54:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RukYq-0006CN-Cq for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:54:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukYq-0006CH-6D for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:54:16 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q17CsETW017449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Feb 2012 07:54:14 -0500 Message-ID: <4F311EF3.9080104@redhat.com> Date: Tue, 07 Feb 2012 13:54:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328342612-25826-1-git-send-email-pbonzini@redhat.com> <1328342612-25826-4-git-send-email-pbonzini@redhat.com> <87wr7yom0x.fsf@elfo.elfo> In-Reply-To: <87wr7yom0x.fsf@elfo.elfo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: qemu-devel@nongnu.org On 02/07/2012 01:39 PM, Juan Quintela wrote: >> > vmmouse = isa_try_create(isa_bus, "vmmouse"); >> > + qdev_init_nofail(&vmmouse->qdev); >> > + qdev_connect_gpio_out(DEVICE(vmmouse), 0, >> > + qdev_get_gpio_in(DEVICE(i8042), 0)); > Are you sue that vmmouse is always non-NULL? My understanding is that > all callers check if is_try_create() return NULL. > > Could you clarify? No, I couldn't. :) You're right. Paolo