From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RumzD-0007XS-5t for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:29:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rumz1-0002XQ-7j for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:29:39 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:39302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rumz1-0002XG-5H for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:29:27 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Feb 2012 10:29:25 -0500 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id C2B246E8506 for ; Tue, 7 Feb 2012 10:25:10 -0500 (EST) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q17FP8oI084418 for ; Tue, 7 Feb 2012 10:25:08 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q17FOrfk032027 for ; Tue, 7 Feb 2012 13:24:54 -0200 Message-ID: <4F31422E.8090804@us.ibm.com> Date: Tue, 07 Feb 2012 09:24:30 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328623766-12287-1-git-send-email-armbru@redhat.com> <1328623766-12287-5-git-send-email-armbru@redhat.com> In-Reply-To: <1328623766-12287-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 02/07/2012 08:09 AM, Markus Armbruster wrote: > Cleaned up silently in commit aad04cd0, but that just got reverted. > Re-apply this part. > > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > qemu-char.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index c25863a..bb9e3f5 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1226,10 +1226,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) > } > tty_serial_init(fd, 115200, 'N', 8, 1); > chr = qemu_chr_open_fd(fd, fd); > - if (!chr) { > - close(fd); > - return NULL; > - } > chr->chr_ioctl = tty_serial_ioctl; > chr->chr_close = qemu_chr_close_tty; > return chr;