From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RunI7-0007DX-Jz for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:49:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RunHz-0007aX-Rn for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:49:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RunHz-0007X8-FW for qemu-devel@nongnu.org; Tue, 07 Feb 2012 10:49:03 -0500 Message-ID: <4F3148BC.7000400@redhat.com> Date: Tue, 07 Feb 2012 16:52:28 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1328623766-12287-1-git-send-email-armbru@redhat.com> <1328623766-12287-11-git-send-email-armbru@redhat.com> In-Reply-To: <1328623766-12287-11-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Am 07.02.2012 15:09, schrieb Markus Armbruster: > This part takes care of backends "file", "pipe", "pty" and "stdio". > Unlike many other backends, these leave open error reporting to their > caller. Because the caller doesn't know what went wrong, this results > in a pretty useless error message. > > Change them to report their errors. Improves comically user-hostile > messages like this one for "-chardev file,id=foo,path=/x" > > chardev: opening backend "file" failed > > to > > qemu-system-x86_64: -chardev file,id=foo,path=/x: Can't create file '/x': Permission denied > chardev: opening backend "file" failed > > The useless "opening backend failed" message will be cleaned up > shortly. > > Signed-off-by: Markus Armbruster > --- > qemu-char.c | 19 +++++++++++++++---- > 1 files changed, 15 insertions(+), 4 deletions(-) > @@ -1002,7 +1013,7 @@ static CharDriverState *qemu_chr_open_pty(QemuOpts *opts) > chr->filename = g_malloc(len); > snprintf(chr->filename, len, "pty:%s", q_ptsname(master_fd)); > qemu_opt_set(opts, "path", q_ptsname(master_fd)); > - fprintf(stderr, "char device redirected to %s\n", q_ptsname(master_fd)); > + error_printf("char device redirected to %s\n", q_ptsname(master_fd)); > > s = g_malloc0(sizeof(PtyCharDriver)); > chr->opaque = s; Not really an error message. Does it make any sense at all to have this message? Kevin