From: "Andreas Färber" <afaerber@suse.de>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, Evgeny Voevodin <e.voevodin@samsung.com>,
Dmitry Solodkiy <d.solodkiy@samsung.com>
Subject: Re: [Qemu-devel] Restore consistent formatting
Date: Wed, 08 Feb 2012 16:28:13 +0100 [thread overview]
Message-ID: <4F32948D.4000303@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1202081903270.1498@linmac>
Am 08.02.2012 16:04, schrieb malc:
> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>
>> Arbitrarily reformatting your files is not okay. If you want a different
>> formatting, you need to fix checkpatch.pl first to not error on that
>> formatting in your files.
>
> It was always formatter like this (internally consistent), then others
> added code which made it not so.
That's not the point. We use the checkpatch.pl script to check the
formatting of patches, we tell contributors to run it. If you want your
files to have an additional space then _you_ would have to change the
script to not error on that formatting in certain files or else your
formatting changes will get reverted again in the parts other people touch.
Right now you silently caused a needless conflict with other people's
patches, including device_init() -> type_init().
That's a really great way to say "I'm back" after lots of 'mail
receiving disabled' messages...
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-02-08 15:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 10:11 [Qemu-devel] Restore consistent formatting Evgeny Voevodin
2012-02-08 12:41 ` Andreas Färber
2012-02-08 15:04 ` malc
2012-02-08 15:23 ` Anthony Liguori
2012-02-08 15:36 ` Andreas Färber
2012-02-08 15:48 ` Anthony Liguori
2012-02-11 9:19 ` Blue Swirl
2012-02-11 12:18 ` Andreas Färber
2012-02-09 9:48 ` Markus Armbruster
2012-02-09 13:46 ` Anthony Liguori
2012-02-11 9:05 ` Blue Swirl
2012-02-08 15:28 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F32948D.4000303@suse.de \
--to=afaerber@suse.de \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).