From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9Rf-00013u-7o for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv9RP-00005Q-TV for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39986 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9RP-00005D-NF for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:15 -0500 Message-ID: <4F32948D.4000303@suse.de> Date: Wed, 08 Feb 2012 16:28:13 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Restore consistent formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Blue Swirl , qemu-devel@nongnu.org, Evgeny Voevodin , Dmitry Solodkiy Am 08.02.2012 16:04, schrieb malc: > On Wed, 8 Feb 2012, Andreas F?rber wrote: >=20 >> Arbitrarily reformatting your files is not okay. If you want a differe= nt >> formatting, you need to fix checkpatch.pl first to not error on that >> formatting in your files. >=20 > It was always formatter like this (internally consistent), then others > added code which made it not so. That's not the point. We use the checkpatch.pl script to check the formatting of patches, we tell contributors to run it. If you want your files to have an additional space then _you_ would have to change the script to not error on that formatting in certain files or else your formatting changes will get reverted again in the parts other people touc= h. Right now you silently caused a needless conflict with other people's patches, including device_init() -> type_init(). That's a really great way to say "I'm back" after lots of 'mail receiving disabled' messages... Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg