From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvGwO-0005de-Ew for qemu-devel@nongnu.org; Wed, 08 Feb 2012 18:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvGwK-00025n-DN for qemu-devel@nongnu.org; Wed, 08 Feb 2012 18:28:44 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:41814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvGwK-00025i-90 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 18:28:40 -0500 Received: by obbup16 with SMTP id up16so1843441obb.4 for ; Wed, 08 Feb 2012 15:28:39 -0800 (PST) Sender: Richard Henderson Message-ID: <4F330523.2060409@twiddle.net> Date: Wed, 08 Feb 2012 15:28:35 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1328714879-18906-1-git-send-email-avi@redhat.com> In-Reply-To: <1328714879-18906-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On 02/08/2012 07:27 AM, Avi Kivity wrote: > This patchset makes the memory core (memory.c) talk to the backend (in exec.c) > via a MemoryListener instead of named functions. > > While the motivation for this is to simplify the memory core, it also enables > optimizing accelerators some more (by having a tcg MemoryListener to do tcg > specific core) and allows unit testing of memory.c (by adding a testing > MemoryListener and seeing what it outputs as various inputs are fed into the > core). > > Avi Kivity (10): > ioport: change portio_list not to use memory_region_set_offset() > memory: remove memory_region_set_offset() > memory: add shorthand for invoking a callback on all listeners > memory: switch memory listeners to a QTAILQ > memory: code motion: move MEMORY_LISTENER_CALL() > memory: move ioeventfd ops to MemoryListener > memory: add a readonly attribute to MemoryRegionSection > memory: don't pass ->readable attribute to > cpu_register_physical_memory_log > memory: use a MemoryListener for core memory map updates too > memory: drop AddressSpaceOps Looks good. Reviewed-by: Richard Henderson r~