From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Dmitry Solodkiy <d.solodkiy@samsung.com>,
qemu-devel@nongnu.org, Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after
Date: Thu, 09 Feb 2012 10:23:29 +0100 [thread overview]
Message-ID: <4F339091.3010906@redhat.com> (raw)
In-Reply-To: <1328767876-357-1-git-send-email-peter.maydell@linaro.org>
On 02/09/2012 07:11 AM, Peter Maydell wrote:
> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
> were accidentally trying to set one of the arm_sysctl properties
> after device init. This has now become a fatal error; set the property
> before device init where it should be done instead.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> If somebody would like to commit this simple patch quickly that would
> probably be a good idea since these models are otherwise totally broken...
Thanks Peter!
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2012-02-09 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 6:11 [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after Peter Maydell
2012-02-09 9:23 ` Paolo Bonzini [this message]
2012-02-09 12:15 ` Paul Brook
2012-02-09 12:34 ` Andreas Färber
2012-02-09 12:37 ` Andreas Färber
2012-02-09 13:18 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F339091.3010906@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).