From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQE9-0002e4-3i for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:23:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvQE1-00080o-Dc for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:23:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQE1-00080T-6f for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:23:33 -0500 Message-ID: <4F339091.3010906@redhat.com> Date: Thu, 09 Feb 2012 10:23:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328767876-357-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1328767876-357-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , Dmitry Solodkiy , qemu-devel@nongnu.org, Evgeny Voevodin , patches@linaro.org On 02/09/2012 07:11 AM, Peter Maydell wrote: > The ARM devboard models (vexpress-a9, realview, versatilepb, etc) > were accidentally trying to set one of the arm_sysctl properties > after device init. This has now become a fatal error; set the property > before device init where it should be done instead. > > Signed-off-by: Peter Maydell > --- > If somebody would like to commit this simple patch quickly that would > probably be a good idea since these models are otherwise totally broken... Thanks Peter! Reviewed-by: Paolo Bonzini Paolo