From: Jan Kiszka <jan.kiszka@web.de>
To: anthony@codemonkey.ws, avi@redhat.com, mtosatti@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies)
Date: Thu, 09 Feb 2012 11:06:57 +0100 [thread overview]
Message-ID: <4F339AC1.6080700@web.de> (raw)
In-Reply-To: <20120209095823.GE22832@truffala.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On 2012-02-09 10:58, David Gibson wrote:
> On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote:
>> Looks like the subject would warmly welcome a "kvm:" tag.
>>
>> On 2012-02-09 05:22, David Gibson wrote:
> [snip]
>>
>> What about naming the problem instead:
>>
>> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */
>
> Just once, it would be nice to post something to this list and get a
> substantive comment _before_ the bitching about minutiae.
>
> Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)==4,
> which includes ppc64 amongst other 64-bit hosts.
Then state "if int is 32 bits". The comment is unfortunately not helpful
without the commit log.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-02-09 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 4:22 [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) David Gibson
2012-02-09 8:30 ` Jan Kiszka
2012-02-09 9:58 ` David Gibson
2012-02-09 10:06 ` Jan Kiszka [this message]
2012-02-09 12:07 ` Paul Brook
2012-02-09 14:11 ` Jan Kiszka
2012-02-10 6:45 ` David Gibson
2012-02-10 6:43 ` David Gibson
2012-02-10 7:27 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F339AC1.6080700@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).