From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQuF-00039y-KQ for qemu-devel@nongnu.org; Thu, 09 Feb 2012 05:07:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvQu9-00009C-K9 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 05:07:11 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:39007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQu9-00008n-CT for qemu-devel@nongnu.org; Thu, 09 Feb 2012 05:07:05 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id BA7C81A9D4A66 for ; Thu, 9 Feb 2012 11:07:03 +0100 (CET) Message-ID: <4F339AC1.6080700@web.de> Date: Thu, 09 Feb 2012 11:06:57 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <4F338411.20408@web.de> <20120209095823.GE22832@truffala.fritz.box> In-Reply-To: <20120209095823.GE22832@truffala.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig10BAA6C9F6FEC01CB300121F" Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws, avi@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10BAA6C9F6FEC01CB300121F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-02-09 10:58, David Gibson wrote: > On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote: >> Looks like the subject would warmly welcome a "kvm:" tag. >> >> On 2012-02-09 05:22, David Gibson wrote: > [snip] >> >> What about naming the problem instead: >> >> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */ >=20 > Just once, it would be nice to post something to this list and get a > substantive comment _before_ the bitching about minutiae. >=20 > Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)=3D=3D4, > which includes ppc64 amongst other 64-bit hosts. Then state "if int is 32 bits". The comment is unfortunately not helpful without the commit log. Jan --------------enig10BAA6C9F6FEC01CB300121F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8zmsQACgkQitSsb3rl5xQQGgCfTsiosCpoSx+JPQcFZxSUoZOw B5UAoLDX7t5RticBUevUCUpAprYygEH1 =8ZTl -----END PGP SIGNATURE----- --------------enig10BAA6C9F6FEC01CB300121F--