From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSgS-0000Q7-6o for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:01:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvSgI-0000sl-AC for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:01:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSgH-0000s0-SQ for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:00:54 -0500 Message-ID: <4F33B56F.5020000@redhat.com> Date: Thu, 09 Feb 2012 13:00:47 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1328698819-31269-1-git-send-email-kraxel@redhat.com> <1328698819-31269-7-git-send-email-kraxel@redhat.com> <20120209085658.GE18866@redhat.com> In-Reply-To: <20120209085658.GE18866@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 02/09/12 09:56, Gleb Natapov wrote: > On Wed, Feb 08, 2012 at 12:00:19PM +0100, Gerd Hoffmann wrote: >> Add a 'wakeup' property to the mc146818rtc. It is on by default. >> When enabled the rtc will wake up the guest when the alarm fires. >> >> Signed-off-by: Gerd Hoffmann >> --- >> hw/mc146818rtc.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c >> index 314ed52..3b912c6 100644 >> --- a/hw/mc146818rtc.c >> +++ b/hw/mc146818rtc.c >> @@ -86,6 +86,7 @@ typedef struct RTCState { >> uint8_t cmos_index; >> struct tm current_tm; >> int32_t base_year; >> + uint32_t wakeup; >> qemu_irq irq; >> qemu_irq sqw_irq; >> int it_shift; >> @@ -437,6 +438,9 @@ static void rtc_update_second2(void *opaque) >> >> s->cmos_data[RTC_REG_C] |= REG_C_AF; >> if (s->cmos_data[RTC_REG_B] & REG_B_AIE) { >> + if (s->wakeup) { >> + qemu_system_wakeup_request(); >> + } > RTC should do wakeup only if RTC_EN bit is set pm1en. --verbose please. Which register, which bit? There is no RTC_EN in hw/mc146818rtc.* ... Is this enable bit specifically for wakeup from suspend? thanks, Gerd