From: "Andreas Färber" <afaerber@suse.de>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Dmitry Solodkiy <d.solodkiy@samsung.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after
Date: Thu, 09 Feb 2012 13:37:06 +0100 [thread overview]
Message-ID: <4F33BDF2.6090402@suse.de> (raw)
In-Reply-To: <4F33BD5F.3040901@suse.de>
Am 09.02.2012 13:34, schrieb Andreas Färber:
> Am 09.02.2012 13:15, schrieb Paul Brook:
>>> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
>>> were accidentally trying to set one of the arm_sysctl properties
>>> after device init. This has now become a fatal error; set the property
>>> before device init where it should be done instead.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> If somebody would like to commit this simple patch quickly that would
>>> probably be a good idea since these models are otherwise totally broken...
>>
>> Done.
>
> Your commit should've contained Paolo's Reviewed-by tag after Peter's
> SoB, and you as committer didn't sign it off either.
>
> http://git.qemu.org/?p=qemu.git;a=commit;h=7a65c8cc315c76bde6d692845c12e7ba06f44f89
...but it's nice that you aid in applying patches again. :)
>
> Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-09 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 6:11 [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after Peter Maydell
2012-02-09 9:23 ` Paolo Bonzini
2012-02-09 12:15 ` Paul Brook
2012-02-09 12:34 ` Andreas Färber
2012-02-09 12:37 ` Andreas Färber [this message]
2012-02-09 13:18 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33BDF2.6090402@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).