From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvTFQ-0003rF-IK for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvTFK-0000OF-Sp for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49696 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvTFK-0000O9-Mi for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:06 -0500 Message-ID: <4F33BDF2.6090402@suse.de> Date: Thu, 09 Feb 2012 13:37:06 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1328767876-357-1-git-send-email-peter.maydell@linaro.org> <201202091215.52550.paul@codesourcery.com> <4F33BD5F.3040901@suse.de> In-Reply-To: <4F33BD5F.3040901@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Peter Maydell , Anthony Liguori , Evgeny Voevodin , patches@linaro.org, qemu-devel@nongnu.org, Dmitry Solodkiy , pbonzini@redhat.com Am 09.02.2012 13:34, schrieb Andreas F=C3=A4rber: > Am 09.02.2012 13:15, schrieb Paul Brook: >>> The ARM devboard models (vexpress-a9, realview, versatilepb, etc) >>> were accidentally trying to set one of the arm_sysctl properties >>> after device init. This has now become a fatal error; set the propert= y >>> before device init where it should be done instead. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> If somebody would like to commit this simple patch quickly that would >>> probably be a good idea since these models are otherwise totally brok= en... >> >> Done. >=20 > Your commit should've contained Paolo's Reviewed-by tag after Peter's > SoB, and you as committer didn't sign it off either. >=20 > http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3D7a65c8cc315c76bde6d692= 845c12e7ba06f44f89 ...but it's nice that you aid in applying patches again. :) >=20 > Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg