From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvUif-0002Ij-Ew for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:11:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvUiZ-00089T-5A for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:11:29 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:45391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvUiY-00089I-TU for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:11:23 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate03.web.de (Postfix) with ESMTP id B872C1AFFA6B4 for ; Thu, 9 Feb 2012 15:11:21 +0100 (CET) Message-ID: <4F33D401.9070608@web.de> Date: Thu, 09 Feb 2012 15:11:13 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <20120209095823.GE22832@truffala.fritz.box> <4F339AC1.6080700@web.de> <201202091207.51350.paul@codesourcery.com> In-Reply-To: <201202091207.51350.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBE2BE6FC45A27D1513677471" Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBE2BE6FC45A27D1513677471 Content-Type: text/plain; charset=ISO-8859-6 Content-Transfer-Encoding: quoted-printable On 2012-02-09 13:07, Paul Brook wrote: >>>> What about naming the problem instead: >>>> >>>> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. *= / >>> >>> Just once, it would be nice to post something to this list and get a >>> substantive comment _before_ the bitching about minutiae. >>> >>> Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)=3D=3D4,= >>> which includes ppc64 amongst other 64-bit hosts. >> >> Then state "if int is 32 bits". The comment is unfortunately not helpf= ul >> without the commit log. >=20 > Int is 32 bits on every host we're ever likey to care about, so clearly= =20 > there's something else going on. Yep. So a better explanation could be "Required for comparison with unsigned IOCTL macro values". This wasn't noticed so far as the original code was never build on anything but IA32/64. Jan --------------enigBE2BE6FC45A27D1513677471 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8z1AYACgkQitSsb3rl5xTz1QCfRLTef3Ko+ILXdxCSQ3dckGSr rx4AoMY/zCeHUwygBSW1rSh5VDXDDUI/ =JMwj -----END PGP SIGNATURE----- --------------enigBE2BE6FC45A27D1513677471--