From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop
Date: Thu, 09 Feb 2012 15:28:01 +0100 [thread overview]
Message-ID: <4F33D7F1.9050709@redhat.com> (raw)
In-Reply-To: <1327962588-5230-1-git-send-email-agraf@suse.de>
Am 30.01.2012 23:29, schrieb Alexander Graf:
> When using Windows 8 with an AHCI disk drive, it issues a blue screen.
> The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not
> supported by our ATA implementation, but Windows expects it to be there.
Is there anything that makes Windows believe that we support it? The
spec says bits in IDENTIFY word 82 and 128 must be set to indicate
support for the security feature set, and we don't set those.
Might be just a Windows bug, of course...
> Since without security stuff implemented, the lock would be a nop anyway
> and CFA_WEAR_LEVEL already is treated as a nop, let's just allow the cmd
> for HD drives as well. That way Windows is happy.
It sets the sector count register to 0, which isn't exactly nop. In any
case, the code would at the very least need a comment that it's used for
two separate commands, so that we still remember this when some time in
the future someone writes a real implementation.
Kevin
next prev parent reply other threads:[~2012-02-09 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 22:29 [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop Alexander Graf
2012-01-30 22:29 ` [Qemu-devel] [PATCH] AHCI: Fix port reset race Alexander Graf
2012-02-09 14:42 ` Kevin Wolf
2012-01-30 22:29 ` [Qemu-devel] [PATCH] AHCI: Masking of IRQs actually masks them Alexander Graf
2012-02-09 14:41 ` Kevin Wolf
2012-02-09 14:52 ` Alexander Graf
2012-02-07 14:57 ` [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop Andreas Färber
2012-02-07 15:01 ` Alexander Graf
2012-02-09 14:28 ` Kevin Wolf [this message]
2012-02-09 14:49 ` Alexander Graf
2012-02-09 14:59 ` Kevin Wolf
2012-02-09 15:01 ` Alexander Graf
[not found] <1335437107-17105-1-git-send-email-agraf@suse.de>
2012-05-02 16:47 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33D7F1.9050709@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).