From: Kevin Wolf <kwolf@redhat.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: stefanha@gmail.com, sheepdog@lists.wpkg.org, hch@lst.de,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix co_recv coroutine context
Date: Thu, 09 Feb 2012 15:48:22 +0100 [thread overview]
Message-ID: <4F33DCB6.4060202@redhat.com> (raw)
In-Reply-To: <1327943406-26444-1-git-send-email-morita.kazutaka@lab.ntt.co.jp>
Am 30.01.2012 18:10, schrieb MORITA Kazutaka:
> The co_recv coroutine has two things that will try to enter it:
>
> 1. The select(2) read callback on the sheepdog socket.
> 2. The aio_add_request() blocking operations, including a coroutine
> mutex.
>
> This patch fixes it by setting NULL to co_recv before sending data.
>
> In future, we should make the sheepdog driver fully coroutine-based
> and simplify request handling.
>
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2012-02-09 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:10 [Qemu-devel] [PATCH] sheepdog: fix co_recv coroutine context MORITA Kazutaka
2012-02-09 14:48 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33DCB6.4060202@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).