From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvVFW-00086Q-UJ for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:45:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvVFS-0007Z4-P2 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:45:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvVFS-0007Z0-EC for qemu-devel@nongnu.org; Thu, 09 Feb 2012 09:45:22 -0500 Message-ID: <4F33DCB6.4060202@redhat.com> Date: Thu, 09 Feb 2012 15:48:22 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1327943406-26444-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> In-Reply-To: <1327943406-26444-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix co_recv coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: stefanha@gmail.com, sheepdog@lists.wpkg.org, hch@lst.de, qemu-devel@nongnu.org Am 30.01.2012 18:10, schrieb MORITA Kazutaka: > The co_recv coroutine has two things that will try to enter it: > > 1. The select(2) read callback on the sheepdog socket. > 2. The aio_add_request() blocking operations, including a coroutine > mutex. > > This patch fixes it by setting NULL to co_recv before sending data. > > In future, we should make the sheepdog driver fully coroutine-based > and simplify request handling. > > Signed-off-by: MORITA Kazutaka Thanks, applied to the block branch. Kevin