From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvX1a-0001Xo-12 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:39:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvX1V-0006cV-3S for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:39:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvX1U-0006cP-Pa for qemu-devel@nongnu.org; Thu, 09 Feb 2012 11:39:05 -0500 Message-ID: <4F33F6A2.50500@redhat.com> Date: Thu, 09 Feb 2012 18:38:58 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1324998680-16003-1-git-send-email-avi@redhat.com> <4EF9EF17.4050703@suse.de> <4F33F23D.9000606@suse.de> In-Reply-To: <4F33F23D.9000606@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] softfloat: fix for C99 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Blue Swirl , Anthony Liguori Cc: qemu-devel@nongnu.org On 02/09/2012 06:20 PM, Andreas F=E4rber wrote: > Am 27.12.2011 17:15, schrieb Andreas F=E4rber: > > Am 27.12.2011 16:11, schrieb Avi Kivity: > >> C99 appears to consider compound literals as non-constants, and comp= lains > >> when they are used in static initializers. Switch to ordinary initi= alizer > >> syntax. > >> > > Reported-by: Andreas F=E4rber > > >> Signed-off-by: Avi Kivity > >=20 > > Acked-by: Andreas F=E4rber > >=20 > > For the record, tested with --extra-cflags=3D-std=3Dgnu99. > >=20 > >> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h > >> index c5e2dab..4902450 100644 > >> --- a/fpu/softfloat-specialize.h > >> +++ b/fpu/softfloat-specialize.h > >> @@ -89,8 +89,8 @@ const float64 float64_default_nan =3D const_float6= 4(LIT64( 0xFFF8000000000000 )); > >> #define floatx80_default_nan_low LIT64( 0xC000000000000000 ) > >> #endif > >> =20 > >> -const floatx80 floatx80_default_nan =3D make_floatx80(floatx80_defa= ult_nan_high, > >> - floatx80_defaul= t_nan_low); > >> +const floatx80 floatx80_default_nan > >> + =3D make_floatx80_init(floatx80_default_nan_high, floatx80_defa= ult_nan_low); > >=20 > > Calling it init_floatx80 would avoid the line break, but I'm okay wit= h > > it either way. > > Ping! Avi, you didn't indicate whether you were going to simplify this > patch or whether you're waiting for someone to apply it as is? > Actually I forgot all about it. If everyone's okay with it as is I'd like it to be applied, otherwise I'll respin. Copying some maintainers completely at random. --=20 error compiling committee.c: too many arguments to function